Skip to content

RHIDP-6568: Create RHDH Metadata card customization content #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

linfraze
Copy link
Member

@linfraze linfraze commented Apr 11, 2025

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Apr 11, 2025

Copy link
Member

@debsmita1 debsmita1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !
Thank you !

@linfraze linfraze added Peer review needed 📖 Technical review done ⛅ Any procedure has been succesfully tested and removed Technical review needed 🔩 Test all the procedures labels Apr 18, 2025

.Procedure

To customize the *{product-very-short} Metadata* card, complete the following step:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider removing this line as fluff, but that's just a nitpick.

Suggested change
To customize the *{product-very-short} Metadata* card, complete the following step:

[id="proc-customizing-rhdh-metadata-card_{context}"]
= Customizing the {product-very-short} Metadata card on the Settings page

The *Settings* page in {product} contains a *{product-very-short} Metadata* card. By default, the *{product-very-short} Metadata* card shows the *{product-very-short} Version* and *Backstage Version* of your {product} instance. When you click the *Show more* icon, the card expands to also show *Upstream*, *Midstream*, and *Build Time* information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@linfraze Small nitpick here, the default view (on RHDH-Local) shows the RHDH version, BS version, upstream, midstream and build time. When you click the icon it contracts to the RHDH version and BS version.

Copy link
Member Author

@linfraze linfraze Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gerry-Forde thank you! Just to confirm, are you using 1.6? Could the RHDH Local default be different?

@debsmita1 can you please confirm that this is what the user sees in the default RHDH Metacard?


.Procedure

To customize the *{product-very-short} Metadata* card, complete the following step:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code snippet that is displayed will completely remove the default RHDH Metadata - is this the intention? I'd suggest that customers will want to see the RHDH Version and Backstage Version at least, so maybe we should leave that in the code snippet?

Screenshot 2025-04-22 at 13 46 08

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gerry-Forde this seems like a Q for PM / Eng.
@debsmita1 can you share your thoughts?

Copy link
Member

@Gerry-Forde Gerry-Forde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@linfraze I left a couple of comments/suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Peer review done 📘 Technical review done ⛅ Any procedure has been succesfully tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants