Fix assign{Ips,Macs} #2
Conversation
|
Great catches, thanks! Could you link a source for the new integer behavior? Is it a |
|
Sure! Here's the original bug report in Lix: https://git.lix.systems/lix-project/lix/issues/423 , which was then cherry-picked to Nix: NixOS/nix#11188 . |
|
That's great, thank you! Could you also link to the upstream |
|
Maybe we should also wait out to see how the discussion at oddlama/nixos-extra-modules#1 (comment) goes 😄 |
|
Relevant: NixOS/nix#13001 |
Half of SHA256 sums truncated to 16 chars actually go over 2^63, which is beyond the range for hexToDec. This fixes the integer overflow error in Lix 2.91+ and Nix 2.25+, as well as undefined behaviour for versions below.
GeoffreyFrogeye
force-pushed
the
push-pzpnnwstpnyq
branch
from
769c41a to
9eaab91
Compare
|
@spacekitteh Woah, this is very cool to see proper bit shift implementations moving forward already! It might still be a bit before this lands in stable, so I went ahead with @reo101 's great suggestion and added some comments in the code itself. I now realize you asked to specifically mention the PR, I noted the Lix/Nix versions. Hmm, people can still refer to the changelogs this way, which allows to keep the comments not too verbose either. But just say the word and I'll change it :) I also added a warning about what still doesn't work as noted in oddlama/nixos-extra-modules#1 (comment) . |
One is trivial, the other one is described more in details in its commit.