ES6 -> JavaScript module with "module": "esmodule"
#838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cometkim is attempting to deploy a commit to the ReScript Association Team on Vercel. A member of the Team first needs to authorize it. |
cometkim
commented
Apr 11, 2024
Comment on lines
+67
to
68
| import * as LeftPad from "./leftPad"; | ||
| var paddedResult = LeftPad("hi", 5); |
There was a problem hiding this comment.
@module external leftPad: (string, int) => string = "./leftPad" let paddedResult = leftPad("hi", 5)
btw, this is a problematic example that only works with transpilers such as Babel or TypeScript (a.k.a synthetic default) and does not work with standard modules.
fhammerschmidt
approved these changes
Apr 12, 2024
|
sorry, I merged your other PR and created a conflict, can you fix it then we are good to go? |
|
no problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As follows rescript-lang/rescript#6709