Add group relationships #126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added get_relationship_requests and unimplemented get_relationships
Added RowIterator
Added GroupRelationship And GroupRelationshipRequest
renamed starting_row_index to row_index, removed unused fields, added rows field, fixed bug where sortOrder would be sent as the actual python object instead of Asc or Desc, fixed next row logic
Moved GroupRelationship and GroupRelationshipRequest to basegroup.py for better organization
Removed import from groups.py, moved GroupRelationshipType above GroupRelationship for better organization, moved GroupRelationship and GroupRelationshipRequest from groups.py, added remove method to GroupRelationship, added accept and decline method to GroupRelationshipRequest, renamed BaseGroup.get_relationship_requests to get_ally_relationship_requests and added docs, added BaseGroup.request_relationship, BaseGroup.decline_relationship_requests and BaseGroup.accept_relationship_requests
Removed unused import
improved typing
improved docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add group relationships
Implements Issue: #124
All features have been implemented and are in working condition, but they have not been tested thoroughly just yet, so I marked this pull request as a draft until then.