-
-
Notifications
You must be signed in to change notification settings - Fork 100
Adding State Management Options to CLI #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 49216ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@theblondealex is attempting to deploy a commit to the ronin-tech Team on Vercel. A member of the Team first needs to authorize it. |
060c31f
to
673f031
Compare
@theblondealex Will explore adding this to the CLI once I move NativeWindUI to the styles section, aiming to do so this weekend. |
663810b
to
b5340ed
Compare
c2b8852
to
ccee444
Compare
@theblondealex planning to review this for the next version of CES (next week) |
I really wish to see this in the CLI |
Just updated it to resolve some conflicts with the recent main branch push |
Have you tested this while also using 'react-native-mmkv' ? Having a hard time finding examples of this setup and even more so if including @TanStack-Query. |
Those are separate packages to zustand and aren't exactly state managers so most likely wouldnt be in here IMO, this is the Redux/zustand type packages |
Hey sorry that its taken a while but I will be looking to get things moving on the state management templates and will be taking a look at this pr soon with the aim to move forward and get it merged. |
There were some weird things that seem to have been messed up from merge conflicts probably, I think i managed to resolve them though |
Awesome does anything else need to be done? Can I help in any way? |
I think we're all good, just made a few more adjustments, just running tests locally to check base case edit: tests passing |
@danstepanov your change request is blocking merge could you take a look, I think we can go ahead with this as is. I'll merge the redux changes in basically right after this is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@theblondealex we're having trouble with rebasing this branch, looks like the commit history got a bit messed up. Can you try rebasing against main? alternatively if thats not working maybe recreating the branch? |
8c1fbe0
to
552c047
Compare
552c047
to
8f6977e
Compare
@dannyhw I have squashed the commits and rebased it against the latest, this inadvertedly closed the PR so reopened it now and it should be ready to merge |
just ran everything locally and looks like we're good |
Description
I had added state management options to the ces flow
This creates a folder in the root directory called state management with a default store from the zustand docs, it could be updated in future with a more generic store and some comments on how to use but to start with its the default store from zustand docs
Motivation and Context
My motivation was as I believe that ces can and should become one of the best and number one go to option for starting new RN expo apps and state management is mandatory in almost every app asit scales and having the setup from the get go is a must, as well as this the intuitive nature of ces means that for beginner RN devs they can use it and this will ease them into state management, in short ces should have eveything you could need, state management is one such item
Screenshots (if appropriate):