Skip to content

US-1842 Users want to save their contacts outside of the app so that when they reset the app they can get their contacts back #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

TravellerOnTheRun
Copy link
Collaborator

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-03-01.at.13.45.20.mp4

Long awaited feature, now users data will be preserved if they wish to, data like domains, contacts, profile data.

Copy link
Contributor

@jormelCoin jormelCoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @TravellerOnTheRun, I saw two issues in this PR and both are related to the save my data button:

1- If I press the save my data button and kill the app, I should appear on the screen create or import a new wallet. However, it shows up on the pin screen and it's redirected to the home screen with my previous information.

20240302_135907.mp4

2- If I click the save my data button and go to the create new wallet flow, the main screen displays the transaction from my prior wallet.

20240302_134100.mp4

@TravellerOnTheRun
Copy link
Collaborator Author

Hey @TravellerOnTheRun, I saw two issues in this PR and both are related to the save my data button:

1- If I press the save my data button and kill the app, I should appear on the screen create or import a new wallet. However, it shows up on the pin screen and it's redirected to the home screen with my previous information.

20240302_135907.mp4
2- If I click the save my data button and go to the create new wallet flow, the main screen displays the transaction from my prior wallet.

20240302_134100.mp4

  1. Isn't that the whole point to save the data? The txs included?

@TravellerOnTheRun
Copy link
Collaborator Author

Hey @TravellerOnTheRun, I saw two issues in this PR and both are related to the save my data button:

1- If I press the save my data button and kill the app, I should appear on the screen create or import a new wallet. However, it shows up on the pin screen and it's redirected to the home screen with my previous information.

20240302_135907.mp4
2- If I click the save my data button and go to the create new wallet flow, the main screen displays the transaction from my prior wallet.

20240302_134100.mp4

  1. I will check it out, this is android specific, I did not test that.

@TravellerOnTheRun
Copy link
Collaborator Author

Hey @TravellerOnTheRun, I saw two issues in this PR and both are related to the save my data button:

1- If I press the save my data button and kill the app, I should appear on the screen create or import a new wallet. However, it shows up on the pin screen and it's redirected to the home screen with my previous information.

20240302_135907.mp4
2- If I click the save my data button and go to the create new wallet flow, the main screen displays the transaction from my prior wallet.

20240302_134100.mp4

  1. Fixed! That was Emulator specific since we store keys in mmkv when in dev and using emulator to ease the development.
  2. I can remove the txs, of course, but we expect adding contact feature from ActivtiyTx soon, it might come in handy. The only thing that does not make sense to preserve is balances. Even though the ticket says contacts, I went futher and preserved domains, txs, contacts and user data.

Copy link
Contributor

@jormelCoin jormelCoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TravellerOnTheRun, The info (contact, tx,rns, etc.) should be related to the wallet. I can't delete my personal wallet and create a new one where I'd like to have other information, but when I open the new one, the other info comes to this one.

Consider the following scenario: I have two wallets, "A" and "B," and all of my information is in wallet A. If I import wallet A, all of its information should be displayed; however, if I import wallet B, no information should appear. At the same time, if I create a new

20240319_180608.mp4

wallet, nothing should be displayed because it is new and does not contain anything.

@jormelCoin
Copy link
Contributor

jormelCoin commented Mar 19, 2024

@TravellerOnTheRun , apart from that, I was unable to run the app on Android. I got this error:

  • Where:
    Build file '/Users/jormel/IOV/swallet/android/app/build.gradle' line: 220
  • What went wrong:
    A problem occurred evaluating project ':app'.
    path may not be null or empty string. path='null'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants