-
Notifications
You must be signed in to change notification settings - Fork 10
DAO-1212 Make sure environment is smooth to run without incompatibility of local deps #944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents builds from failing due to global gem mismatches by requiring pod install to run through Bundler-managed environment. Added yarn scripts for pod:install and pod:update.
Dependency ReviewThe following issues were found:
OpenSSF ScorecardScorecard details
Scanned Files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
vendor/bundle
) to avoid global version mismatches.cocoapods
,activesupport
, and Ruby 2.7.NO_FLIPPER
) for better consistency when Flipper is turned off.Gemfile.lock
,Podfile.lock
, and project binstubs to match new dependency versions and execution flow.pod:install
andpod:update
scripts inpackage.json
to standardize pod management.Why
pod install
could cause hidden and hard-to-debug issues due to environment differences.Enforcing Bundler ensures every developer (and CI) uses the correct, project-specific CocoaPods version.
activesupport
upgrades beyond compatibility range withcocoapods
, which could break builds.NO_FLIPPER
is set.pod
).How to test
npx react-native-clean-project
and choosey
for all the options related toios
andnode_modules
.yarn install
pod install
should work unless via Bundler (vendor/bundle
).yarn pod:install
Evidence
yarn pod:install
succeeds.NO_FLIPPER=1
.PR resolved by this one
#917
#926
#927