Skip to content

Add increaseUnionBridgeLockingCap method to the Bridge class #3118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: use-union-increaseLockingCap-method
Choose a base branch
from

Conversation

nathanieliov
Copy link
Contributor

Add increaseUnionBridgeLockingCap method to the Bridge class

How Has This Been Tested?

Unit Tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)

@nathanieliov nathanieliov requested a review from a team as a code owner May 8, 2025 13:20
Copy link

github-actions bot commented May 8, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@nathanieliov nathanieliov force-pushed the use-union-increaseLockingCap-method branch 3 times, most recently from 95b5c44 to 5589571 Compare May 8, 2025 18:16
@nathanieliov nathanieliov force-pushed the use-bridgeSupport-union-increaseLockingCap-method branch 2 times, most recently from 315a088 to 3bd22be Compare May 9, 2025 12:04
Copy link

sonarqubecloud bot commented May 9, 2025

Copy link
Contributor

@jeremy-then jeremy-then left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

- Added MAX RBTC constant to UnionBridgeConstants
- Added unit tests for increaseLockingCap method
- Added MAX RBTC constant to UnionBridgeConstants
- Added unit tests for increaseLockingCap method
- Added unit tests for increaseUnionBridgeLockingCap method
- Added MAX RBTC constant to UnionBridgeConstants
- Added unit tests for increaseLockingCap method
@nathanieliov nathanieliov force-pushed the use-bridgeSupport-union-increaseLockingCap-method branch from 3bd22be to 601d4bf Compare May 23, 2025 20:48
@nathanieliov nathanieliov force-pushed the use-union-increaseLockingCap-method branch from 5589571 to de86b5d Compare May 23, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants