Implement Digest::CRC32 #86
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: ruby#77 `CRC32` is relatively commonly needed for network protocol and some archive formats like `zip`. This is a clean implementation derived from the Wikipedia article.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #77
CRC32is relatively commonly needed for network protocol (e.g. erro checking in AWS-s3, etc) and some archive formats likezip. As such it would be helpful to have a reasonably efficient implementation built-in.This is a clean implementation derived from the Wikipedia article, there are more optimized implementations out there, but not sure it's really worth including complicated code. I mostly meant this as a way to familiarize myself with
digestbefore I attempt to write a PR for BLAKE-3.About JRuby, I tried to figure out how to implement another Java digest, but I couldn't figure it out. It seems like the digest them isn't actually doing any digest and the actual code is in
jrubyitself? @headius is that correct? If so, how am I supposed to addcrc32support?