Skip to content

Add try_map_results method. #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions src/adaptors/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1260,6 +1260,56 @@ impl<I, F, T, U, E> Iterator for FilterMapOk<I, F>
}).collect()
}
}

/// An iterator adapter to apply a fallible transformation within a nested `Result`.
///
/// See [`.map_and_then()`](../trait.Itertools.html#method.map_and_then) for more information.
#[derive(Clone)]
#[must_use = "iterator adaptors are lazy and do nothing unless consumed"]
pub struct MapAndThen<I, F> {
iter: I,
f: F
}

/// Create a new `MapAndThen` iterator.
pub fn map_and_then<I, F, T, U, E>(iter: I, f: F) -> MapAndThen<I, F>
where I: Iterator<Item = Result<T, E>>,
F: FnMut(T) -> Result<U, E>
{
MapAndThen {
iter: iter,
f: f,
}
}

impl<I, F, T, U, E> Iterator for MapAndThen<I, F>
where I: Iterator<Item = Result<T, E>>,
F: FnMut(T) -> Result<U, E>
{
type Item = Result<U, E>;

fn next(&mut self) -> Option<Self::Item> {
self.iter.next().map(|v| v.and_then(&mut self.f))
}

fn size_hint(&self) -> (usize, Option<usize>) {
self.iter.size_hint()
}

fn fold<Acc, Fold>(self, init: Acc, mut fold_f: Fold) -> Acc
where Fold: FnMut(Acc, Self::Item) -> Acc,
{
let mut f = self.f;
self.iter.fold(init, move |acc, v| fold_f(acc, v.and_then(&mut f)))
}

fn collect<C>(self) -> C
where C: FromIterator<Self::Item>
{
let mut f = self.f;
self.iter.map(move |v| v.and_then(&mut f)).collect()
}
}

/// An iterator adapter to get the positions of each element that matches a predicate.
///
Expand Down
19 changes: 19 additions & 0 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ pub mod structs {
Batching,
MapInto,
MapOk,
MapAndThen,
Merge,
MergeBy,
TakeWhileRef,
Expand Down Expand Up @@ -811,6 +812,24 @@ pub trait Itertools : Iterator {
adaptors::filter_map_ok(self, f)
}

/// Return an iterator adaptor that applies the provided fallible
/// closure to every `Result::Ok` value. `Result::Err` values in
/// the original iterator are unchanged.
///
/// ```
/// use itertools::Itertools;
///
/// let input = vec![Ok(41), Err(false), Ok(i32::max_value())];
/// let it = input.into_iter().map_and_then(|i| i.checked_add(1).ok_or(true));
/// itertools::assert_equal(it, vec![Ok(42), Err(false), Err(true)]);
/// ```
fn map_and_then<F, T, U, E>(self, f: F) -> MapAndThen<Self, F>
where Self: Iterator<Item = Result<T, E>> + Sized,
F: FnMut(T) -> Result<U, E>,
{
adaptors::map_and_then(self, f)
}

/// Return an iterator adaptor that merges the two base iterators in
/// ascending order. If both base iterators are sorted (ascending), the
/// result is sorted.
Expand Down