Skip to content

chore: lint ctest-test crate #4413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: lint ctest-test crate #4413

wants to merge 2 commits into from

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Apr 15, 2025 •
edited
Loading

run cargo clippy --all-targets on ctest-test, and fix all default issues

@rustbot label +stable-nominated

@rustbot
Copy link
Collaborator

rustbot commented Apr 15, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added ctest Issues relating to the ctest crate S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Apr 15, 2025
@nyurik nyurik force-pushed the ctest-test-lints branch 4 times, most recently from df8cafb to a9b5944 Compare April 15, 2025 18:47
tgross35
tgross35 requested changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note, ctest isn't on the libc-0.2 branch at all so there are no backports needed for these changes.

@tgross35 tgross35 added S-waiting-on-review stable-unneeded This PR is applied to main but already exists on libc-0.2 S-waiting-on-author and removed S-waiting-on-author stable-nominated This PR should be considered for cherry-pick to libc's stable release branch S-waiting-on-review labels Apr 15, 2025
@nyurik
chore: lint ctest-test crate
f91bf9c 
run `cargo clippy --all-targets` on `ctest-test`, and fix all default issues. Also added a generic
@nyurik nyurik force-pushed the ctest-test-lints branch from a9b5944 to f91bf9c Compare April 21, 2025 14:22
@nyurik nyurik requested a review from tgross35 April 21, 2025 14:29
@nyurik nyurik force-pushed the ctest-test-lints branch from 3a56cd8 to 9367edd Compare April 21, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 Awaiting requested review from tgross35

Requested changes must be addressed to merge this pull request.

Assignees

@tgross35 tgross35

Labels
ctest Issues relating to the ctest crate S-waiting-on-review stable-unneeded This PR is applied to main but already exists on libc-0.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nyurik @rustbot @tgross35