-
Notifications
You must be signed in to change notification settings - Fork 1.6k
manual_div_ceil
: fix suggestions when macro is involved
#14666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to clippy @Kivooeo! :) Just some meta information on opening PRs for Clippy:
There is no need to cc the issue author unless necessary. We'd want to minimize ping for other people. |
@dswij thanks for the quick review, check this changes ive made, is this any better or need any corrections? |
dswij
reviewed
Apr 22, 2025
@dswij should be done, double check everything pls |
@rustbot ready |
dswij
reviewed
Apr 24, 2025
dswij
approved these changes
Apr 27, 2025
Thank you! @Kivooeo |
manual_div_ceil
: fix suggestions when macro is involved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
here is my small fix
changelog: fix suggestion span to avoid showing macro name in
.div_ceil()
suggestioni changed this line
let divisor_snippet = snippet_with_applicability(cx, rhs.spansource_callsite(), "..", applicability);
to this line
let divisor_snippet = snippet_with_applicability(cx, rhs.span, "..", applicability);
to fix problem where this warning in macro expands like this
play it yourself
as you can see here it looks like
x.div_ceil(y!())
and contains macro signatureso i fixed this problem, i will look closely if there any more problems like this and fix them in order
Related issue
fixes rust-lang/rust-clippy#14665