Soft rename clippy::all to clippy::default
#14689
Open
+28
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
smoelius
reviewed
Apr 24, 2025
| @@ -0,0 +1,11 @@ | |||
| // Tests that `clippy::all` still works without a deprecation warning | |||
There was a problem hiding this comment.
Sorry to intrude, but why don't you want a deprecation warning?
There was a problem hiding this comment.
It's starting as a soft deprecation since it's very widely used, it may eventually become a warning
There was a problem hiding this comment.
I would not deprecate it. I don't think it is ever worth to do so. I think clippy::all is older than 5 years by now. It will take at least the same amount of time until clippy::default is used in more places than clippy::all, I would think. So maybe really really long-term, we can deprecate it. But that might even be the decision of a different set of people by then.
Plus, I don't see any downsides in keeping it.
flip1995
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @flip1995
For now I haven't updated the docs since people read the current README/etc for stable usage
changelog:
clippy::allhas been renamed toclippy::default, existing uses ofclippy::alldo not need to be changed