convert between two implementations of fin-dim algebras #39970
+300
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 2f11478; changes) is ready! 🎉 |
tscrim
requested changes
Apr 21, 2025
src/sage/algebras/finite_dimensional_algebras/finite_dimensional_algebra.py
Outdated
Show resolved
Hide resolved
src/sage/algebras/finite_dimensional_algebras/finite_dimensional_algebra.py
Outdated
Show resolved
Hide resolved
src/sage/algebras/finite_dimensional_algebras/finite_dimensional_algebra.py
Outdated
Show resolved
Hide resolved
src/sage/algebras/finite_dimensional_algebras/finite_dimensional_algebra.py
Show resolved
Hide resolved
This provides functionality for converting between two implementations of finite-dimensional algebras: - the modern one, implemented as MagmaticAlgebras.WithBasis.FiniteDimensional in sage.categories.magmatic_algebras (in the magmatic case) and as FiniteDimensionalAlgebrasWithBasis in sage.categories.finite_dimensional_algebras_with_basis (in the assocative case), and - the old one, implemented as FiniteDimensionalAlgebra in sage.algebras.finite_dimensional_algebras.finite_dimensional_algebra. To be more precise, the latter now automatically inherits from the former if the optional parameters assume_associative and assume_unital are set to True, whereas the former can be converted into the latter via the to_finite_dimensional_algebra method. This way, the methods of one (e.g. ``center_basis`` on the modern one or ``is_unitary`` on the old one) can be used on the other. Fixing various other issues in both classes as well.
…ic) linear algebra operations.
|
I made a few changes:
Since I made these online, I didn't check that they actually worked; will wait for the bots. |
|
Good edits, Travis! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides functionality for converting between two implementations of finite-dimensional algebras:
This way, the methods of one (e.g.
center_basison the modern one oris_unitaryon the old one) can be used on the other.I hope they actually work, though -- hard to tell without having a contract for the modern class...