-
-
Notifications
You must be signed in to change notification settings - Fork 601
Added a bandwidth feature #39978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Added a bandwidth feature #39978
Conversation
Documentation preview for this PR (built with commit c1e2d8a; changes) is ready! 🎉 |
The order of operations could be improved by visiting the matrix by diagonals and stop as soon as a non zero value is found. it is best to visit simultaneously the upper and the lower diagonals. I'm not sure that the method should be called |
@dcoudert For the namesake, I wasn't careful to see that there is a method with the same name but different behavior implemented elsewhere. In that case, naming it the same would not be appropriate, will change to As for using So to clarify what you proposed, you're saying if I go through every diagonal starting from the corner to the main diagonal via |
I don't think it's necessary.
Precisely and this is what was proposed in the original patch #13565. The idea is to stop computation as soon as possible. This should be an improvement for large matrix. |
#13565
Added a bandwidth feature that gives the bandwidth of a matrix. The bandwidth of a matrix measures how far from the main diagonal the nonzero entries extend. Mostly used for storage efficiency / reordering to speed up solvers etc. For now it is just a new feature to add.
📝 Checklist
⌛ Dependencies
cc @tscrim