Skip to content

fix: log as method gives symbolic output for non positive base #39986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

devansh-srv
Copy link
Contributor

This pull request updates the behaviour of the log method in the Integer class to handle cases where the base is non-positive to give symbolic output and added tests for the same. This solves the issue #39959
like this

sage: 8.log(-2)
3*log(2)/(I*pi + log(2))

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@devansh-srv devansh-srv marked this pull request as ready for review April 21, 2025 07:54
Copy link

github-actions bot commented Apr 21, 2025

Documentation preview for this PR (built with commit 6a97484; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant