-
-
Notifications
You must be signed in to change notification settings - Fork 608
Always use python to run the pexpect interface #39996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
sage-ipython is no longer available in the meson build
Documentation preview for this PR (built with commit a6b5fa4; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I'm getting
|
Now one test has timeout issues (see meson ci). @vbraun would it be possible to preinstall a suitable python on the bots so that they don't use sage's python build? |
Some tests spawn a sage subshell which changes the prompt and confuses the expect instance
Should be fine now, please review again |
sagemathgh-39996: Always use python to run the pexpect interface sage-ipython is no longer available in the meson build Fixes sagemath#39869 URL: sagemath#39996 Reported by: Antonio Rojas Reviewer(s): Tobias Diez
sagemathgh-39996: Always use python to run the pexpect interface sage-ipython is no longer available in the meson build Fixes sagemath#39869 URL: sagemath#39996 Reported by: Antonio Rojas Reviewer(s): Tobias Diez
sagemathgh-39996: Always use python to run the pexpect interface sage-ipython is no longer available in the meson build Fixes sagemath#39869 URL: sagemath#39996 Reported by: Antonio Rojas Reviewer(s): Tobias Diez
sage-ipython is no longer available in the meson build
Fixes #39869