Skip to content

docs(Modal): carousel example #5101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged

docs(Modal): carousel example #5101

merged 1 commit into from
May 15, 2025

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • Documentation

Summarise concisely:

What is expected?

Add an example of carousel in modal.

Relevant logs and/or screenshots

Screen.Recording.2025-05-06.at.17.07.23.mov

@matthprost matthprost requested a review from a team May 6, 2025 15:11
@matthprost matthprost self-assigned this May 6, 2025
@matthprost matthprost requested review from johnrazeur and radhi-nasser-scaleway and removed request for a team May 6, 2025 15:11
@matthprost matthprost requested a review from lisalupi as a code owner May 6, 2025 15:11
@matthprost matthprost added the documentation Improvements or additions to documentation label May 6, 2025
Copy link

changeset-bot bot commented May 6, 2025

⚠️ No Changeset found

Latest commit: 995fab1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.71%. Comparing base (302eadc) to head (995fab1).
Report is 27 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #5101       +/-   ##
=========================================
+ Coverage      0   88.71%   +88.71%     
=========================================
  Files         0      236      +236     
  Lines         0     8349     +8349     
  Branches      0     3741     +3741     
=========================================
+ Hits          0     7407     +7407     
- Misses        0      942      +942     

see 236 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 302eadc...995fab1. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matthprost matthprost merged commit 7c6f223 into main May 15, 2025
15 checks passed
@matthprost matthprost deleted the docs/add-carousel-example branch May 15, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants