Skip to content

feature: serialize JSON LabelSet as array of strings #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

jkongie
Copy link
Collaborator

@jkongie jkongie commented Apr 24, 2025

This commit improves the JSON serialization of the LabelSet struct by changing the way labels are represented in JSON. Instead of using a map with string keys and string values, the labels are now represented as an array of strings. This change simplifies the JSON structure and makes it easier to work with labels in a more intuitive way.

@jkongie jkongie requested a review from a team as a code owner April 24, 2025 03:40
Copy link

changeset-bot bot commented Apr 24, 2025

🦋 Changeset detected

Latest commit: 8ab1a27

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
chainlink-deployments-framework Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jkongie jkongie force-pushed the label-set-json-as-array branch from 64d93d2 to b6aeaa7 Compare April 24, 2025 03:44
This commit improves the JSON serialization of the LabelSet struct by
changing the way labels are represented in JSON. Instead of using a
map with string keys and string values, the labels are now represented
as an array of strings. This change simplifies the JSON structure and
makes it easier to work with labels in a more intuitive way.
@jkongie jkongie force-pushed the label-set-json-as-array branch from b6aeaa7 to 8ab1a27 Compare April 24, 2025 03:48
@jkongie jkongie added this pull request to the merge queue Apr 24, 2025
Merged via the queue into main with commit 416e1a4 Apr 24, 2025
6 checks passed
@jkongie jkongie deleted the label-set-json-as-array branch April 24, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants