fix: separate title and message in progress bar [IDE-1067]

[rrama]

Since the language server has to conform to the LSP, we are bound by how the progress bars are defined there, as such it makes sense to align the GAF progress bar with it.

[rrama]

In the future I would like to split the ProgressBar interface into two types of progress bar, one representing infinite progress and other quantifiable progress. Something like:

type UserInterface interface {
	Output(output string) error
	OutputError(err error, opts ...Opts) error
-->     NewProgressBar(title string, message string) ProgressBar
-->     NewProgressBarInfinite(title string, message string) ProgressBarInfinite
	Input(prompt string) (string, error)
}
type ProgressBar interface {
	UpdateProgress(progress float64) error
	UpdateProgressWithMessage(progress float64, message string) error
	Clear() error
}

// ProgressBarInfinite is like ProgressBar, but without a reported percentage,
// so the spinner is infinite.
type ProgressBarInfinite interface {
	SetMessage(message string) error
	Clear() error
}

(It is reasonably trivial to have the underlying consoleProgressBar struct be being duck-typeable to bother interfaces)

But alas, that change ended up being too large for now. So I have parked it here: https://github.com/snyk/go-application-framework/tree/fix/progress-bar-v3

[PeterSchafer]

Question: @rrama did you integrate these changes in the CLI? I assume given that this PR changes interfaces, it'll require changes to existing extensions. Did you consider doing this without a breaking change?

[rrama]

@PeterSchafer, for the CLI it requires merging the old SetTtitle into the NewProgressBar in cliv2/cmd/cliv2/debug.go and then for cli-extension-iac the same again in internal/commands/iactest/ui.go. I can make PRs ready to merge before this gets merged.

I had considered doing it without any knock on changes to the CLI, it would leave the interface being less intuitive to use, as the LS would have to ignore SetTitles after the first UpdateProgress is called. I am hoping this impact is minor enough, but if not then let me know and I can do a zero knock on changes.