Skip to content

Fail fast when both management 'base path' and 'endpoint mapping' are set to '/' #45251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fail fast when both management 'base path' and 'endpoint mapping' are set to '/' #45251

wants to merge 1 commit into from
+40 −0

Conversation

YongGoose
Copy link
Contributor

fixes #43885

@YongGoose YongGoose mentioned this pull request Apr 22, 2025
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 22, 2025
@YongGoose
Add fail-fast mechanism when both management base path and `endpo…
775af26 
…int mapping` are set to '/'

- Issue spring-projects#43885

Signed-off-by: yongjunhong <dev.yongjunh@gmail.com>
@philwebb philwebb changed the title Add fail-fast mechanism when both management base path and endpoint mapping are set to '/' Add 'fail-fast' mechanism when both management 'base path' and 'endpoint mapping' are set to '/' Apr 22, 2025
@philwebb philwebb changed the title Add 'fail-fast' mechanism when both management 'base path' and 'endpoint mapping' are set to '/' Fail fast when both management 'base path' and 'endpoint mapping' are set to '/' Apr 22, 2025
@philwebb philwebb self-assigned this Apr 22, 2025
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 22, 2025
@philwebb philwebb added this to the 3.5.0-RC1 milestone Apr 22, 2025
philwebb pushed a commit that referenced this pull request Apr 22, 2025
@YongGoose @philwebb
Fail fast when base path and an endpoint mapping are set to '/'
8f535b2 
Throw an exception if actuator is running on the main server port and
the base path and an individual mapping are set to '/'.

See gh-45251

Signed-off-by: yongjunhong <dev.yongjunh@gmail.com>
philwebb added a commit that referenced this pull request Apr 22, 2025
@philwebb
Polish 'Fail fast when base path and an endpoint mapping are set to '/''
7dac8ca 
See gh-45251
@philwebb philwebb closed this in 82a2cbb Apr 22, 2025
@philwebb
Copy link
Member

Thanks very much @YongGoose. I've tweaked things a little to relocate the code to WebEndpointAutoConfiguration so that it also applies to Jersey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@philwebb philwebb

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.5.0-RC1
Development

Successfully merging this pull request may close these issues.

Fail fast if management base path and an endpoint mapping are both '/' on the main server port
3 participants
@YongGoose @philwebb @spring-projects-issues