refactor: update math/base/special/atanh according to the FreeBSD implementation
#6179
+35
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neerajpathak07
force-pushed
the
refactor-atanh
branch
from
a6d226a to
52b85a0
Compare
|
Had to rebase due to addition of an unwanted change. |
Neerajpathak07
commented
Mar 19, 2025
| @@ -18,7 +18,7 @@ | |||
| * | |||
| * ## Notice | |||
| * | |||
| * The following copyright, license, and long comment were part of the original implementation available as part of [FreeBSD]{@link https://svnweb.freebsd.org/base/release/9.3.0/lib/msun/src/e_atanh.c?view=markup}. The implementation follows the original, but has been modified for JavaScript. | |||
| * The following copyright, license, and long comment were part of the original implementation available as part of [FreeBSD]{@link https://svnweb.freebsd.org/base/release/12.2.0/lib/msun/src/e_atanh.c?view=markup}. The implementation follows the original, but has been modified for JavaScript. | |||
There was a problem hiding this comment.
Have updated the link to the new version of FreeBSD
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
@kgryte Have made the changes in the C implementation according to the issue description. Will be working on the |
|
cc:- @gunjjoshi |
stdlib-bot
added
the
Potential Duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2089.
Description
This pull request:
math/base/special/atanhaccording to the FreeBSD implementation.Related Issues
This pull request:
math/base/special/atanhaccording to the FreeBSD implementation #2089Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers