Skip to content

feat: add stats/incr/nanmrange #6310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

coehemang
Copy link

Resolves #5605 .

Description

What is the purpose of this pull request?

This pull request:

  • Adds the @stdlib/stats/incr/nanmrange package, which computes moving range incrementally while handling NaN values by ignoring them.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Modified test cases are passing.

image

Examples with NaN generated successfully

image

All 6 benchmarks are passed

image

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 22, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 22, 2025

Coverage Report

Package Statements Branches Functions Lines
stats/incr/nanmrange $\color{green}142/142$
$\color{green}+100.00\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}142/142$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter self-requested a review April 16, 2025 00:06
@kgryte kgryte changed the title feat: added wrapper to moving range incrementally computing function for ignoring NaN values. feat: added wrapper to moving range incrementally computing function for ignoring NaN values Apr 16, 2025
@kgryte kgryte changed the title feat: added wrapper to moving range incrementally computing function for ignoring NaN values feat: add stats/incr/nanmrange Apr 16, 2025
@Planeshifter
Copy link
Member

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 16, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 16, 2025
@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Apr 22, 2025
@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 23, 2025
@stdlib-bot
Copy link
Contributor

/stdlib

@coehemang, slash command not recognized. Please use /stdlib help to view available commands.

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 23, 2025
@coehemang
Copy link
Author

/stdlib help

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 23, 2025
@stdlib-bot
Copy link
Contributor

@coehemang, available slash commands include:

  • /stdlib check-files - Check for required files.
  • /stdlib make-commands - Print make commands for package changed in PR.
  • /stdlib update-copyright-years - Update copyright header years.
  • /stdlib lint-autofix - Auto-fix lint errors.
  • /stdlib merge - Merge changes from develop branch into this PR.
  • /stdlib rebase - Rebase this PR on top of develop branch.

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 23, 2025
@coehemang
Copy link
Author

/stdlib lint-autofix

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 23, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 23, 2025
@coehemang
Copy link
Author

@Planeshifter , @kgryte : I am trying to run the linting command on local environment to fix issues, but it keeps failing and gives an error that eslint-plugin-stdlib is not found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Changes Pull request which needs changes before being merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: add stats/incr/nanmrange
3 participants