fix: orphan object client detector #672
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 14575349690Details
💛 - Coveralls |
itslenny
approved these changes
Apr 21, 2025
src/scripts/orphan-client.ts
Outdated
| import path from 'path' | ||
|
|
||
| const ADMIN_URL = '' | ||
| const ADMIN_API_KEY = '' |
There was a problem hiding this comment.
Can we pull these values from process.env instead? I'd just like to eliminate the chance of accidentally pushing a commit with secrets. Using node 20+ we can just use the --env-file flag so we don't need any 3rd party libraries to support this.
fenos
force-pushed
the
fix/orphan-client
branch
from
b29a7ae to
e58e9a6
Compare
fenos
force-pushed
the
fix/orphan-client
branch
from
e58e9a6 to
c0e4d8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the new behavior?
Client-side tool to interact with the object scanner to list and/or detect orphan objects.
Additional context
This tool has 2 commands:
listanddeleteIn both operations, detected orphans' references are saved to disk.
Is recommended to run the list command before delete