Add Darwin as a supported platform type for #if os
#1685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NSAntoine
changed the title
#if os#if os
NSAntoine
changed the title
#if os#if os
|
LGTM |
|
This is an Apple platform owner concern, so I've reached out to the appropriate people at Apple, and it's being pre-reviewed. I'll update this PR with the results of that conversation. |
Hi, I had a moment and was revisiting some of the old proposals I made to try to get them across the finish line. Do you happen to recall what the results of this discussion were? |
|
Hi @SerenaKit, there is an ongoing conversation over on the Swift Forums based on the internal discussions at Apple. |
rjmccall
added
LSG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.