[DNM] [rebranch] Adjust some tests to pass again #81190
Open
+1,233
−1,233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
requested review from
eeckstein,
zoecarver,
egorzhdan,
Xazax-hun,
j-hui,
fahadnayyar,
susmonteiro,
hnrklssn,
rjmccall,
ktoso and
adrian-prantl
as code owners
|
@swift-ci please smoke test macOS |
bnbarham
reviewed
Apr 30, 2025
AnthonyLatsis
force-pushed
the
rebranch-fix-tests
branch
from
4abe8f5 to
4a3340e
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
1 similar comment
|
@swift-ci please smoke test macOS |
|
@aschwaighofer do we actually care about checking for |
Per 7eca38ce76d5d1915f4ab7e665964062c0b37697 (llvm-project).
…ign` Per b7db403e701029c801fd990dceeb219de9fb800c (llvm-project).
…(none)` Per 29441e4f5fa5f5c7709f7cf180815ba97f611297 (llvm-project).
The current regex does not match a ')' inside the argument list. This no longer works because `nocapture` became `captures(none) in 29441e4f5fa5f5c7709f7cf180815ba97f611297 (llvm-project). Use a wildcard regex instead. This is fine because the `unnamed_addr` attribute the test is guarding against can only appear after the argument list.
…er attribute The `initializes` parameter attribute was introduced in 5ece35df8586d0cb8c104a9f44eaae771de025f5 (llvm-project). The lowered function bodies indicate that the attribute is correct. Match the attribute using a wildcard regex because it appears only in -O mode and is not relevant to these tests.
The new attribute is `captures(ret: address, provenance)`. This attribute is expected because these functions either immediately return the pointer argument or pass it as an argument to another such parameter. Match it using a wildcard regex See https://llvm.org/docs/LangRef.html#parameter-attributes.
The new attribute is `range(i8 -127, -128)`. The documentation specifies that the range can wrap, meaning that for i8 [-127, -128) is equivalent to [-127, 127). This is expected for a function that simply increments a i8 value. Match the attribute using a wildcard regex because it appears only in -O mode and is not relevant to the test. See https://llvm.org/docs/LangRef.html#parameter-attributes.
…hanged `alias nocapture swiftself` -> `alias swiftself captures(none)`. `nocapture` became `captures(none) in 29441e4f5fa5f5c7709f7cf180815ba97f611297 (llvm-project).
AnthonyLatsis
force-pushed
the
rebranch-fix-tests
branch
from
4a3340e to
9915205
Compare
|
@swift-ci please test macOS |
AnthonyLatsis
changed the title
| @@ -24,7 +24,7 @@ func foo(_ x: inout Int64) { | |||
| // IRCHECK-NEXT: call void @llvm.memset.{{.*}}(ptr align {{(4|8)}} %[[X]], i8 0 | |||
| // IRCHECK: store ptr %0, ptr %[[X]], align {{(4|8)}} | |||
| // IRCHECK-SAME: !dbg ![[LOC0:.*]] | |||
| // IRCHECK-NEXT: %[[VALUE:.*]] = getelementptr inbounds %Ts5Int64V, ptr %0, i32 0, i32 0, | |||
| // IRCHECK-NEXT: %[[VALUE:.*]] = getelementptr inbounds nuw %Ts5Int64V, ptr %0, i32 0, i32 0, | |||
|
@swift-ci please smoke test macOS |
|
@swift-ci please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.