Skip to content
This repository was archived by the owner on Apr 20, 2025. It is now read-only.

Generate PublicKey from PrivateKey #187

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bliepp
Copy link

@bliepp bliepp commented Jan 9, 2022

I know it's not that much of an important feature as a public key can be generated from a private key by simply doing

pubkey = rsa.PublicKey(privkey.n, privkey.e)

but I still find a separate method to be convenient as it eliminates a possible source of errors and increases readability.

With the rather simple implementation this would be just

pubkey = privkey.public_key()

@sybrenstuvel
Copy link
Owner

Thanks for the PR. I agree with you that it's good to have a dedicated method for this.

Before I can accept the PR it needs a bit of love, though. The new code should be covered by a unit test.

Maybe you could also write a little bit about this in the "Generating Keys" section of doc/usage.rst? Such new, useful functionality ought to be documented as well.

@bliepp
Copy link
Author

bliepp commented Jan 11, 2022

Thank you for your reply. I've written a test case in the KeyGenTest class and some documentation into usage.rst as you suggested.

Hope this is fine now.

@bliepp
Copy link
Author

bliepp commented Jan 20, 2022

It's been a week since I fixed this PR. Is this okay now or is there something I need to change?

@sybrenstuvel
Copy link
Owner

From a glance it looks good, thanks. For personal reasons I can't spend more brain power on this now, sorry. I'll get back to you, no worries. If there happen to be things to change, I'll be explicit in what & how.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants