[Monolog] Update monolog_email.rst #14439
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matts
suggested changes
Oct 27, 2020
| @@ -194,6 +194,10 @@ actually deals with emailing you the error. The settings for this are | |||
| straightforward, the to and from addresses, the formatter, the content type | |||
| and the subject. | |||
|
|
|||
| .. tip:: | |||
|
|
|||
| If you use messenger, make sure that your message class implements ``\JsonSerializable`` in order to get the message content in your logs, because messenger uses his monolog directly and his context serializer wish use ``json_encode`` for seriliazation. That's why we need to customize JSON representation when encoded is done with ``json_encode``. | |||
There was a problem hiding this comment.
Hi @ahmed-bhs!
Can you explain what you are trying to say here:
"because messenger uses his monolog directly and his context serializer wish use json_encode for sterilization."
maybe I can give some suggestions to make it more clear :)
|
@OskarStark I think you use Symfony Messenger a lot so, could you please check if we could merge/reword this somehow? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.