[Notifier] Add Engagespot bridge #16165
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danut007ro
changed the title
This was referenced Nov 27, 2021
OskarStark
reviewed
Nov 27, 2021
OskarStark
requested changes
Nov 27, 2021
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
|
Please retarget |
|
Done, but tests are failing, seems unrelated |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Mar 26, 2022
This PR was squashed before being merged into the 6.1 branch. Discussion ---------- Add Engagespot bridge | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | no ticket | License | MIT | Doc PR | symfony/symfony-docs#16165 Add [Engagespot](https://engagespot.co/) integration for push notifications. Commits ------- c7e1d1a Add Engagespot bridge
symfony-splitter
pushed a commit
to symfony/notifier
that referenced
this pull request
Mar 26, 2022
This PR was squashed before being merged into the 6.1 branch. Discussion ---------- Add Engagespot bridge | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | no ticket | License | MIT | Doc PR | symfony/symfony-docs#16165 Add [Engagespot](https://engagespot.co/) integration for push notifications. Commits ------- c7e1d1a78e Add Engagespot bridge
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Mar 26, 2022
This PR was squashed before being merged into the 6.1 branch. Discussion ---------- Add Engagespot bridge | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | no ticket | License | MIT | Doc PR | symfony/symfony-docs#16165 Add [Engagespot](https://engagespot.co/) integration for push notifications. Commits ------- c7e1d1a78e Add Engagespot bridge
OskarStark
approved these changes
Mar 27, 2022
|
Can you please rebase? This should make the CI green. Thanks |
|
@danut007ro sorry it took us so long to take care of your contribution. I was going to merge it, but there was lots of conflicts while merging. I couldn't fix those, so I recreated your changes directly in e16e05a Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation about engagespot integration
symfony/symfony#44303