[DependencyInjection][HttpKernel] document Autowire attribute
#16629
+93
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbond
force-pushed
the
autowire-attribute
branch
from
b7ee351 to
a7c791f
Compare
|
I believe the "Code Blocks" action will be fixed with #16627. |
BafS
reviewed
Apr 9, 2022
controller.rst
Outdated
| // ... | ||
|
|
||
| /** | ||
| * @Route("/lucky/number/{max}") |
There was a problem hiding this comment.
Maybe something to do in another PR, but why don't we use the attribute style? Especially with this feature from Symfony 6.1
There was a problem hiding this comment.
Agree, was just following the method from the other examples in this file. Probably a separate PR is best.
BafS
reviewed
Apr 9, 2022
BafS
approved these changes
Apr 11, 2022
kbond
force-pushed
the
autowire-attribute
branch
from
ba58c0d to
f32aec1
Compare
|
Thank you @kbond. Pretty cool feature, and with great docs :) I've moved things around, to not duplicate too much. To be honest, the service container articles need some rewriting in general, so the place is not ideal at the moment, but I think having it in the autowiring article makes most sense. |
javiereguiluz
added a commit
that referenced
this pull request
May 4, 2022
…kbond) This PR was squashed before being merged into the 6.1 branch. Discussion ---------- [DependencyInjection] adjust `Autowire` attribute docs Follow up to #16629 per slack discussion. For services and expressions, explicitly use the named argument. Commits ------- fd05739 [DependencyInjection] adjust `Autowire` attribute docs
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony PRs: symfony/symfony#45657 & symfony/symfony#45783
Closes #16625.
Closes #16636