Skip to content

chore: Add missing semicolon #17577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2022
Merged

chore: Add missing semicolon #17577

merged 1 commit into from
Dec 18, 2022

Conversation

TheKhanj
Copy link
Contributor

No description provided.

mdoutreluingne
mdoutreluingne approved these changes Dec 17, 2022
View reviewed changes
Copy link
Contributor

@mdoutreluingne mdoutreluingne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
(note for the mergers: this can be merged in 5.4)

@OskarStark OskarStark added this to the 5.4 milestone Dec 17, 2022
@OskarStark
Copy link
Contributor

Thanks @mdoutreluingne these information are very helpful. I added the 5.4 milestone.

@TheKhanj thanks for the fix, we take care of merging it into 5.4 👌🏻

@javiereguiluz javiereguiluz changed the base branch from 6.2 to 5.4 December 18, 2022 10:36
@javiereguiluz
Copy link
Member

@TheKhanj thanks and congrats on your first Symfony Docs contribution 🎉

Thanks to reviewers too 🙌

@javiereguiluz javiereguiluz merged commit daaeccf into symfony:5.4 Dec 18, 2022
@TheKhanj
Copy link
Contributor Author

Thank you all, I am really flattered, you know I just added a single semicolon :), I didn't expect much appreciation :) ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@mdoutreluingne mdoutreluingne mdoutreluingne approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@TheKhanj @OskarStark @javiereguiluz @mdoutreluingne @carsonbot