Skip to content

docs(DomCrawler): remove hint about html5-php library #17908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Feb 16, 2023

html5-php is mandatory after symfony/symfony#44170

@carsonbot
Copy link
Collaborator

Hey!

Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/
Could you update the PR base branch to target one of these branches instead? 5.4, 6.2, 6.3.

Cheers!

Carsonbot

@carsonbot carsonbot added this to the 6.1 milestone Feb 16, 2023
@kesselb kesselb changed the base branch from 6.1 to 6.2 February 16, 2023 10:25
@javiereguiluz
Copy link
Member

Thanks Daniel! We've merged this in 6.2 and 6.3 branches.

javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Feb 17, 2023
…rary (kesselb)

This PR was merged into the 6.2 branch.

Discussion
----------

docs(DomCrawler): remove hint about html5-php library

html5-php is mandatory after symfony/symfony#44170

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/releases for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `6.x` for features of unreleased versions).

-->

Commits
-------

1be7e33 docs(DomCrawler): remove hint about html5-php library
@xabbuh xabbuh closed this Feb 19, 2023
@kesselb kesselb deleted the patch-1 branch February 20, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants