Skip to content

[HttpClient][Mime] support overwriting form encoding #18002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: 6.3
Choose a base branch
from

Conversation

croensch
Copy link

@croensch croensch commented Mar 4, 2023

It's not really relevant to the Mime / Email docs because that will use Base64 by default.

I've tried to keep it short, i'm not sure it's good though.

See PR symfony/symfony#49587 and issue symfony/symfony#49315

Verified

This commit was signed with the committer’s verified signature.
@carsonbot carsonbot added this to the 6.3 milestone Mar 4, 2023
@OskarStark OskarStark added the Waiting Code Merge Docs for features pending to be merged label Mar 5, 2023
@carsonbot carsonbot modified the milestones: 6.3, next Mar 5, 2023
@OskarStark
Copy link
Contributor

Versionadded directive is missing.

Can you please use named parameters and remove the null, null? Thanks

@OskarStark OskarStark added the Mime label May 7, 2023
@carsonbot carsonbot changed the title [HttpClient] support overwriting form encoding [HttpClient][Mime] support overwriting form encoding May 7, 2023
Copy link
Author

@croensch croensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OskarStark you think this wording is okay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants