Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the example suggests to execute this code when doing edit
this is wrong in couple of ways
First the
setBrochureFilename
method expects string and not aFile
instance. No error is thrown because theFile
instance can be casted tostring
and will return the full path, which is not what's needed. In the database field you need to store the filename only, and not the full path.Second the form expects
File
instance and not the entity. This is why the form data needs to be changed and not the entity.In the 4.4 branch it's the same.