Skip to content

fix(notification-channels): add support to Slack private channels #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 29, 2025

Conversation

akahenry
Copy link
Contributor

@akahenry akahenry commented Apr 28, 2025

This PR is an attempt to fix the error described on this issue.

Considering that the isPrivateChannel (together with the privateChannelUrl) field from the Sysdig Create Notification Channel API isn't supported by this Terraform provider, I'm adding it with this PR hoping that this will be sufficient to fix the error.

I didn't test myself the changes because I don't really have an environment where I could do such a thing. However, if you have any suggestions on how I could achieve/build one for that I would appreciate it.

@akahenry akahenry force-pushed the fix-slack-private-channels-error branch from 346204a to fa950b7 Compare April 28, 2025 19:23
@dbonf dbonf force-pushed the fix-slack-private-channels-error branch 2 times, most recently from 48d49ac to 936c797 Compare April 29, 2025 12:14
@dbonf dbonf force-pushed the fix-slack-private-channels-error branch from 936c797 to acafa4f Compare April 29, 2025 14:20
@dbonf
Copy link
Collaborator

dbonf commented Apr 29, 2025

thanks for this contribution, originally we were on the fence on supporting private slack channels in terraform (see some work on the old branch https://github.com/sysdiglabs/terraform-provider-sysdig/tree/slack-support-private-channel) as this is a peculiar feature, but i can see the value of having it when importing existing notification channels. I took the liberty to add to your work and add some refinements.

@dbonf dbonf self-assigned this Apr 29, 2025
@dbonf dbonf force-pushed the fix-slack-private-channels-error branch from acafa4f to 8f0daa7 Compare April 29, 2025 14:46
@dbonf dbonf merged commit bf4e4b0 into sysdiglabs:master Apr 29, 2025
23 checks passed
@akahenry
Copy link
Contributor Author

thanks for this contribution, originally we were on the fence on supporting private slack channels in terraform (see some work on the old branch https://github.com/sysdiglabs/terraform-provider-sysdig/tree/slack-support-private-channel) as this is a peculiar feature, but i can see the value of having it when importing existing notification channels. I took the liberty to add to your work and add some refinements.

That's awesome! Thank you all for the quick reply and solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants