-
Notifications
You must be signed in to change notification settings - Fork 53
fix(notification-channels): add support to Slack private channels #634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(notification-channels): add support to Slack private channels #634
Conversation
c0765a1
to
346204a
Compare
346204a
to
fa950b7
Compare
48d49ac
to
936c797
Compare
936c797
to
acafa4f
Compare
thanks for this contribution, originally we were on the fence on supporting private slack channels in terraform (see some work on the old branch https://github.com/sysdiglabs/terraform-provider-sysdig/tree/slack-support-private-channel) as this is a peculiar feature, but i can see the value of having it when importing existing notification channels. I took the liberty to add to your work and add some refinements. |
acafa4f
to
8f0daa7
Compare
That's awesome! Thank you all for the quick reply and solution. |
This PR is an attempt to fix the error described on this issue.
Considering that the
isPrivateChannel
(together with theprivateChannelUrl
) field from the Sysdig Create Notification Channel API isn't supported by this Terraform provider, I'm adding it with this PR hoping that this will be sufficient to fix the error.I didn't test myself the changes because I don't really have an environment where I could do such a thing. However, if you have any suggestions on how I could achieve/build one for that I would appreciate it.