Advance timer properly during JIT execution #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Apr 28, 2025
There was a problem hiding this comment.
Benchmarks
| Benchmark suite | Current: a27625b | Previous: 5001cfd | Ratio |
|---|---|---|---|
Dhrystone |
1285 Average DMIPS over 10 runs |
1087 Average DMIPS over 10 runs |
0.85 |
Coremark |
915.126 Average iterations/sec over 10 runs |
915.504 Average iterations/sec over 10 runs |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
vacantron
force-pushed
the
timer
branch
2 times, most recently
from
f478189 to
e2a430a
Compare
vacantron
requested review from
jserv and
ChinYikMing
and removed request for
ChinYikMing
ChinYikMing
reviewed
Apr 29, 2025
ChinYikMing
approved these changes
Apr 29, 2025
jserv
reviewed
Apr 29, 2025
jserv
changed the title
In the current implementation, the timer would not be updated until the control flow exits the JIT-ed code. This commit updates the timer correctly after every instruction has been dispatched.
|
Thank @vacantron for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, the timer would not be updated until the control flow exits the JIT-ed code. This commit updates the timer correctly after every instruction has been dispatched.
Summary by Bito
This pull request enhances the timer functionality in the JIT execution context by replacing the static counter with a dynamic timer variable. It introduces new methods for timer management in JIT compilation and T2C generation, improving the accuracy of time-related operations.Unit tests added: False
Estimated effort to review (1-5, lower is better): 2 - The changes are straightforward and well-defined, making the review process relatively simple.