Skip to content

Upgrade thirdweb to v5.100.1 and update UserOp handling for gas overrides #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025

Conversation

d4mr
Copy link
Member

@d4mr d4mr commented May 22, 2025

PR-Codex overview

This PR updates the thirdweb package version and modifies the send-transaction-worker.ts file to enhance the transaction handling process by adding new types and improving user operation preparation and signing.

Detailed summary

  • Updated thirdweb from 5.96.5 to ^5.100.1 in package.json.
  • Added DelayedError import from bullmq.
  • Introduced new types: Address, Chain, ThirdwebClient, and VersionedUserOp.
  • Modified handler function to accept an optional token parameter.
  • Updated _sendUserOp to include token in transaction sending.
  • Refactored user operation preparation and signing logic.
  • Added getEntrypointFromFactory function to retrieve entrypoint addresses.
  • Enhanced error handling for factory address resolution.
  • Improved gas fee handling and job delaying logic.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Refactor
    • Enhanced transaction submission flow with clearer error handling and improved job delay logic for gas fee overrides.
  • Chores
    • Updated the "thirdweb" dependency to allow newer compatible versions.

@d4mr d4mr requested a review from joaquim-verges May 22, 2025 20:06
Copy link

zeet-co bot commented May 22, 2025

We're building your pull request over on Zeet.
Click me for more info about your build and deployment.
Once built, this branch can be tested at: https://tw-unreal-demo-engine-vwn0-pb-use-74e155.engine-aws-usw2.zeet.app before merging 😉

Copy link

coderabbitai bot commented May 22, 2025

Walkthrough

The dependency version for "thirdweb" in package.json was updated to a caret range, allowing newer compatible versions. In src/worker/tasks/send-transaction-worker.ts, the _sendUserOp function was refactored to separate user operation preparation, signing, and bundling phases, with enhanced error handling and new helper functions for resolving contract addresses.

Changes

File(s) Change Summary
package.json Updated "thirdweb" dependency version from "5.96.5" to "^5.100.1".
src/worker/tasks/send-transaction-worker.ts Refactored _sendUserOp to separate preparation, signing, and bundling steps; improved error handling; added helper function for entrypoint resolution; updated type usage; added optional token parameter to functions; enhanced job delay logic.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant Worker
    participant AccountContract
    participant FactoryContract
    participant ThirdwebClient

    Caller->>Worker: Invoke _sendUserOp(job)
    Worker->>AccountContract: (If needed) Call factory() to get factory address
    AccountContract-->>Worker: Return factory address or error
    Worker->>FactoryContract: (If needed) Call entrypoint() to get entrypoint address
    FactoryContract-->>Worker: Return entrypoint address or error
    Worker->>ThirdwebClient: prepareUserOp(...)
    ThirdwebClient-->>Worker: Return prepared user operation or error
    alt Gas fee override check
        Worker-->>Caller: Delay job (if override too low)
    else
        Worker->>ThirdwebClient: signUserOp(...)
        ThirdwebClient-->>Worker: Return signed user operation or error
        Worker->>ThirdwebClient: bundleUserOp(...)
        ThirdwebClient-->>Worker: Return bundled result or error
        Worker-->>Caller: Return sent transaction or error
    end
Loading

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2207433 and 70bbdbd.

📒 Files selected for processing (1)
  • src/worker/tasks/send-transaction-worker.ts (11 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/worker/tasks/send-transaction-worker.ts
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Analyze (javascript-typescript)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

socket-security bot commented May 22, 2025

@d4mr d4mr merged commit fa4369a into main May 22, 2025
8 checks passed
@d4mr d4mr deleted the pb/userop-gas-override-handling branch May 22, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants