oaiFeat: Cli integration test

.eslintrc

@@ -15,6 +15,7 @@
     "sonarjs/no-identical-functions": "off",
     "sonarjs/no-collapsible-if": "off",
     "sonarjs/prefer-immediate-return": "off",
-    "no-throw-literal": "off"
+    "no-throw-literal": "off",
+    "max-classes-per-file": ["error", 3]
   }
 }

.github/scripts/update-release.js

@@ -1,5 +1,7 @@
 const core = require('@actions/core');
 const { Octokit } = require("@octokit/core");
+const path = require('path');
+const fs = require('fs');
 
 /**
  * Functionality from tubone24/update_release.
@@ -12,6 +14,13 @@ const updateRelease = async () => {
     })
     const [owner, repo] = process.env.REPO_NAME ? process.env.REPO_NAME.split('/') : [null, null];
     const tag = process.env.TAG_NAME;
+    const githubWorkspace = process.env.GITHUB_WORKSPACE;
+
+    console.log("GITHUB_WORKSPACE: ", githubWorkspace);
+
+    if( !process.env.GITHUB_WORKSPACE.includes('twilio-cli-core') ) {
+      updatePackageJson(process.env.CLI_CORE_TAG)
+    }
 
     //https://docs.github.com/en/rest/releases/releases#get-a-release-by-tag-name
     const getReleaseResponse = await octokit.request('GET /repos/{owner}/{repo}/releases/tags/{tag}',{
@@ -54,7 +63,7 @@ const updateRelease = async () => {
       prerelease = oldPrerelease;
     }
 
-    //https://docs.github.com/en/rest/releases/releases#update-a-release
+    // https://docs.github.com/en/rest/releases/releases#update-a-release
     await octokit.request('PATCH /repos/{owner}/{repo}/releases/{release_id}', {
       owner,
       release_id: oldReleaseId,
@@ -71,6 +80,26 @@ const updateRelease = async () => {
   }
 };
 
+const updatePackageJson = (value) => {
+  try {
+    // Path to package.json
+    const packageJsonPath = path.resolve(process.cwd(), 'package.json');
+
+    // Read and parse package.json
+    const packageJson = JSON.parse(fs.readFileSync(packageJsonPath, 'utf8'));
+
+    // Update the desired key
+    packageJson["dependencies"]["@twilio/cli-core"] = value;
+
+    // Write the updated object back to package.json
+    fs.writeFileSync(packageJsonPath, JSON.stringify(packageJson, null, 2), 'utf8');
+
+    console.info(`Updated package.json: Set twilio-cli-core to '${value}'`);
+  } catch (error) {
+    console.error(`Failed to update package.json: ${error.message}`);
+  }
+};
+
 module.exports = {
   updateRelease,
 };

.github/workflows/cli-core-audit.yml

@@ -10,14 +10,14 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [18.x, 16.x, 14.x]
+        node-version: [lts/*, 22.x, 20.x]
     steps:
       - name: Checkout cli repo
         uses: actions/checkout@v2
         with:
           fetch-depth: 0
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v2
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
           cache: 'npm'
@@ -32,7 +32,7 @@ jobs:
     name: Notify Npm Audit Failed
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Slack Notification
         uses: rtCamp/action-slack-notify@v2
         env:

.github/workflows/cli-core-test.yml

@@ -10,16 +10,16 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [18.x, 16.x, 14.x]
+        node-version: [lts/*, 22.x, 20.x]
     steps:
       - name: Checkout cli core repo
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
         with:
           # Disabling shallow clone is recommended for improving relevancy of reporting
           fetch-depth: 0
       - run: make install
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v2
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
           cache: 'npm'
@@ -36,7 +36,7 @@ jobs:
     name: Notify Test Failed
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Slack Notification
         uses: rtCamp/action-slack-notify@v2
         env:

.github/workflows/release.yml

@@ -87,13 +87,13 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [14.x, 16.x, 18.x]
+        node-version: [20.x, 22.x, lts/*]
     steps:
       - name: Checkout cli-core repo
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
       - run: make install
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v2
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
           cache: 'npm'
@@ -135,7 +135,7 @@ jobs:
       tag-name: ${{ steps.semantic-release.outputs.TAG_NAME }}
     steps:
       - name: Checkout cli-core repo
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
         with:
           persist-credentials: false
       - run: |
@@ -147,25 +147,26 @@ jobs:
           node-version: 18.x
       - name: semanticRelease
         id: semantic-release
-        run: DEBUG=semantic-release:* npx semantic-release  -t \${version}
+        run: |
+          DEBUG=semantic-release:* npx semantic-release
         env:
           GITHUB_TOKEN: ${{ secrets.REPO_ACCESS_TOKEN }}
           NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
-      - name: Update release
-        run: |
-          fileName="$GITHUB_WORKSPACE/.github/scripts/update-release.js"
-          node -e "require('$fileName').updateRelease()"
-        env:
-          REPO_ACCESS_TOKEN: ${{ github.token }}
-          TAG_NAME: ${{ steps.semantic-release.outputs.TAG_NAME }}
-          RELEASE_BODY: ${{needs.update-api-specs.outputs.change-log}}
-          REPO_NAME:  ${{ github.repository }}
+#      - name: Update release
+#        run: |
+#          fileName="$GITHUB_WORKSPACE/.github/scripts/update-release.js"
+#          node -e "require('$fileName').updateRelease()"
+#        env:
+#          REPO_ACCESS_TOKEN: ${{ github.token }}
+#          TAG_NAME: ${{ steps.semantic-release.outputs.TAG_NAME }}
+#          RELEASE_BODY: ${{needs.update-api-specs.outputs.change-log}}
+#          REPO_NAME:  ${{ github.repository }}
   triggerCliWorkflow:
     runs-on: ubuntu-latest
     needs: [ update-api-specs, release]
     steps:
       - name: Checkout cli-core repo
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
       - run: |
           git pull
           make install
@@ -178,7 +179,8 @@ jobs:
           WORKFLOW_NAME: 'release.yml'
           BRANCH_NAME: ${{github.event.inputs.cli-branch}}
           REPO_NAME:  ${{ github.repository_owner }}/twilio-cli
-          INPUTS: '{ "change-log": ${{ toJSON(needs.update-api-specs.outputs.change-log) }}, "version-type": "${{needs.update-api-specs.outputs.version-type}}", "homebrew-branch": "${{github.event.inputs.homebrew-branch}}", "homebrew-prerelease": "${{github.event.inputs.homebrew-prerelease}}" }'
+          INPUTS: '{ "change-log": "changelog3", "version-type": "2", "homebrew-branch": "${{github.event.inputs.homebrew-branch}}", "homebrew-prerelease": "${{github.event.inputs.homebrew-prerelease}}" }'
+          CLI_CORE_TAG: ${{ needs.release.outputs.tag-name }}
 #  notify-complete-fail:
 #    if: ${{ (needs.cli-token-validation.result != 'failure' || needs.cli-core-token-validation.result != 'failure' ) && (failure() || cancelled()) }}
 #    needs: [ triggerCliWorkflow ]

.releaserc.json

@@ -2,8 +2,8 @@
   "branches": [
     "main",
     {
-      "name": "release-feature-branch",
-      "prerelease": "rc"
+      "name": "cli-integration-test",
+      "prerelease": "alpha"
     }
   ],
   "plugins": [
@@ -58,11 +58,16 @@
         "changelogFile": "CHANGES.md"
       }
     ],
-    "@semantic-release/npm",
+    [
+      "@semantic-release/npm",{
+      "npmPublish": false
+    }
+    ],
     [
       "@semantic-release/github",
       {
-        "successComment": false
+        "successComment": false,
+        "npmPublish": false
       }
     ],
     [