chore: Add Context Values #226
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlejandroOrozco
force-pushed
the
feature/AddContextValues
branch
13 times, most recently
from
613d747 to
f404268
Compare
AlejandroOrozco
force-pushed
the
feature/AddContextValues
branch
2 times, most recently
from
beade08 to
f404268
Compare
yafuquen
reviewed
Mar 3, 2025
.circleci/config.yml
Outdated
| - run: | ||
| name: Setup Certificate and Keychain | ||
| command: | | ||
| # create variables |
fastlane/Fastfile
Outdated
| match( | ||
| type: "development", | ||
| app_identifier: ["com.twilio.verify.HostApp"] | ||
| # match( |
fastlane/Fastfile
Outdated
| type: "development", | ||
| app_identifier: ["com.twilio.verify.AppSizer"] | ||
| ) | ||
| # match( |
There was a problem hiding this comment.
Can we remove the Matchfile?
AlejandroOrozco
force-pushed
the
feature/AddContextValues
branch
2 times, most recently
from
ac6f56e to
e6c4c0b
Compare
yafuquen
approved these changes
Mar 19, 2025
AlejandroOrozco
force-pushed
the
feature/AddContextValues
branch
6 times, most recently
from
b1c2cb9 to
7720a48
Compare
* fix: Gemfile to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-RUBY-REXML-6861566 * Update CircleCI Resources --------- Co-authored-by: snyk-bot <snyk-bot@snyk.io>
* Fix unit test crashing * Fix flaky test * Print received error * Support error when creating keypair with invalid parameters * Test device * Update iOS version to 12 * feat: Support Xcode 16.3 (#229) * feat: Support Xcode 16.3 * feat: Update project to testplans --------- Co-authored-by: Yeimi Moreno <ymoreno@twilio.com> Co-authored-by: Alejandro Orozco <aorozcobuiles@twilio.com>
AlejandroOrozco
force-pushed
the
feature/AddContextValues
branch
from
3011c7e to
88eb0d9
Compare
AuthyApps
reviewed
Apr 24, 2025
| @@ -154,8 +158,8 @@ class FactorAPIClientTests: XCTestCase { | |||
| "Authorization header should not be nil") | |||
| XCTAssertNotNil(networkProvider.urlRequest?.allHTTPHeaderFields![HTTPHeader.Constant.userAgent], | |||
| "User agent header should not be nil") | |||
| XCTAssertEqual(String(decoding: networkProvider.urlRequest!.httpBody!, as: UTF8.self), params.asString(), | |||
| "Body should be \(params.asString()) but was \(networkProvider.urlRequest!.httpBody!)") | |||
| XCTAssert(String(decoding: networkProvider.urlRequest!.httpBody!, as: UTF8.self) == params.asString() || String(decoding: networkProvider.urlRequest!.httpBody!, as: UTF8.self) == paramsv2.asString(), | |||
There was a problem hiding this comment.
Line should be 195 characters or less; currently it has 203 charactersline_length FactorAPIClientTests.swift:161 |
AuthyApps
reviewed
Apr 24, 2025
| @@ -154,8 +158,8 @@ class FactorAPIClientTests: XCTestCase { | |||
| "Authorization header should not be nil") | |||
| XCTAssertNotNil(networkProvider.urlRequest?.allHTTPHeaderFields![HTTPHeader.Constant.userAgent], | |||
| "User agent header should not be nil") | |||
| XCTAssertEqual(String(decoding: networkProvider.urlRequest!.httpBody!, as: UTF8.self), params.asString(), | |||
| "Body should be \(params.asString()) but was \(networkProvider.urlRequest!.httpBody!)") | |||
| XCTAssert(String(decoding: networkProvider.urlRequest!.httpBody!, as: UTF8.self) == params.asString() || String(decoding: networkProvider.urlRequest!.httpBody!, as: UTF8.self) == paramsv2.asString(), | |||
There was a problem hiding this comment.
Prefer failable String(data:encoding:) initializer when converting Data to Stringoptional_data_string_conversion FactorAPIClientTests.swift:161 |
AuthyApps
reviewed
Apr 24, 2025
| XCTAssertEqual(String(decoding: networkProvider.urlRequest!.httpBody!, as: UTF8.self), params.asString(), | ||
| "Body should be \(params.asString()) but was \(networkProvider.urlRequest!.httpBody!)") | ||
| XCTAssert(String(decoding: networkProvider.urlRequest!.httpBody!, as: UTF8.self) == params.asString() || String(decoding: networkProvider.urlRequest!.httpBody!, as: UTF8.self) == paramsv2.asString(), | ||
| "Body should be \(params.asString()) or \(paramsv2.asString()) but was \(String(decoding: networkProvider.urlRequest!.httpBody!, as: UTF8.self))") |
There was a problem hiding this comment.
Prefer failable String(data:encoding:) initializer when converting Data to Stringoptional_data_string_conversion FactorAPIClientTests.swift:162 |
Code coverageTotal coverage:
|
| File | Coverage |
|---|---|
| TwilioVerifySDK/TwilioSecurity/Sources/Key/Template/ECP256SignerTemplate.swift | 93.02% |
| TwilioVerifySDK/TwilioSecurity/Sources/Keychain/Keychain.swift | 88.83% |
Powered by Slather
Generated by 🚫 Danger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Github Issue
Description
Commit message
Screenshot
Testing