-
-
Notifications
You must be signed in to change notification settings - Fork 9
Make planck
more useful (Proposal 26)
#24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I don't like how this changes people's documents without warning. I'm still a bit conflicted on whether that's just a necessary evil or whether we should look into adding some kind of ad-hoc warning in typst before making this change here... |
I guess we could split this into multiple phases if we really want to make sure it does not break people's documents:
I'm not sure it would be worth spanning this over three versions, but if it breaks many documents, I think this is the only way to make a progressive change. |
Hmm..... It may be a bit dumb, but that's probably the most robust way to go about it. The more I think about it, the more I actually like the idea. @laurmaedje would you say this is warranted or is it overkill? |
Very similar to what I proposed here for For |
All this would have to be done on Typst's side, tough. Codex does not have the ability to express such precise warnings. |
After another brief discussion of this on discord, I'll drop my concern for this, so LGTM. |
To be clear, what the next Typst changelog should mention is that |
Description
This PR implements Proposal 26 (iteration 1) from the Symbol Proposals document. It changes
planck
to ħ (which gets italicized to ℏ in math thanks to typst/typst#5492), and removes theplanck.reduce
variant. For more context, see the discussion on Discord.There is no way to take advantage of the symbol deprecation mechanism introduced in #19 to make this change smoother.
Breaking changes (cc. @laurmaedje)
planck.reduce
becomes invalid, andplanck
changes codepoint.