Only rewrite lockfile if the data has changed #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This both improves performance by reducing the number of times that the disk gets written to, and also should fix the bug where the data-type gets changed mistakenly by this plug-in on Composer v2.8.2 or later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This both improves performance by reducing the number of times that the disk gets written to, and also should fix the bug where the data-type gets changed mistakenly by this plug-in on Composer v2.8.2 or later.
In my testing this fixes the bug described in #120. (I'm carefully not using the closing keyword though, so that this can be verified properly.) I still haven't been able to get the test suite working for this plug-in.