-
-
Notifications
You must be signed in to change notification settings - Fork 49
Add grid view to collection list #2403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this makes collection grid simpler: it doesn't include extra editing dialog when not needed Extract collection edit dialog into dedicated component - Move dialog from collections-grid to collections-grid-with-edit-dialog - Update dashboard page to use new composite component
thumbnail when switching pages
b66b482
to
835dd0a
Compare
SuaYoo
reviewed
Apr 21, 2025
SuaYoo
reviewed
Apr 21, 2025
SuaYoo
approved these changes
Apr 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2498
Yay for consistency!
Changes
Adds a grid view to the collections list, alongside the default list view.
collections-grid-with-edit-dialog
component for dashboard — collections list already has its own edit dialog, so no need for this to be duplicated in the grid componentpage
property of pagination component, which fixes the dashboard not switching back to page 1 when switching between "Public" and "All" collection viewsManual testing
Screenshots
Remaining things to do: