-
Notifications
You must be signed in to change notification settings - Fork 850
Detect browser without relying on vendor prefixes #1160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
isn't waiting for https://bugzilla.mozilla.org/show_bug.cgi?id=1750143 easier? |
Merging this PR should have the same net effect (of making the check UA-string based). It might also end up being faster given Mozilla's neutral position on UA client hints. I should have done this a year ago when we discovered this, but we gotta plant the seed at some point. |
Firefox (Nightly) 138 now has While most major video conferencing websites I've tested so far appear to work, we're in contact with one affected by this. They're applying a fix on their end, but getting this merged would probably help them and other consumers of adapter. |
Just trying to get it into the same release as #1127 https://www.reddit.com/r/firefox/comments/1j8401w/another_media_service_fallen_f1tv_is_a_costly/?share_id=qEAEN4EyxZnU9fGVFNaDI&utm_content=2&utm_medium=android_app&utm_name=androidcss&utm_source=share&utm_term=1&rdt=56689 should have demonstrated that UA sniffing is far more costly to Firefox than helping do actual feature detection but... |
Thanks for the link. It's a good example of why we want to get rid of things like Streamlining UA sniffing helps us respond quickly with out-of-band interventions or dot-releases, which might need to include overriding UA strings in cases where websites reactively blocked Firefox. |
This comment was marked as off-topic.
This comment was marked as off-topic.
rebase needed |
Fixes #1156.