-
Notifications
You must be signed in to change notification settings - Fork 7
General Refactor #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TheRustifyer
wants to merge
128
commits into
main
Choose a base branch
from
refactor/GH-65-general-refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
General Refactor #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le all cfg features
…the rust-analyzer LSP in Canyon-SQL
…ase connection instead of panic!
…y the piece of s*** of the public API of tiberius is making us go crazy
…king the internal pool to the user code (yet leaked, will be fixed)
…hat can end be a db_conn more flexible
…nputs to have a db_conn
…to fetch db_conn(s)
…a safe way, while removing unneded complexities and/or unneeded lifetime specifications
…<CanyonRows, ...> providing a better fluent api over the returned results from the database(s)
…mes on trait objects
…ains a whitespace due to quote! processing
…ains a whitespace due to quote! processing
… of a 8x on running the integration tests. This will likely impact the Canyon users with a massive performance boost
…tr for DbConnection
…o a small subset of contracts, according each one functionality
…ilder -> Query Query is the DbConnection type now
…ds from the autogenerated enums, so the argument is now a code entity and not an str
…of a type for giving the user reflection elements over the type ident and the type matching database table name generated by Canyon
…OwnedValue depending on what db configuration features exists
…processed only once per procedural macro creation, and not per method invocation
…atures are enabled
chore: removed the + Display bound on the generic statement parameters that receives the sql sentences
…is internally generated (Care:! We broke the Tiberius implementation because the type requeriments of their api for the moment, is pending to be fixed)
…entors of CrudOperations
…to pass the query parameters
…ding to a much better hygiene on the derive proc macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Legitimate Performance Improvements (likely contributors):
Singleton Initialization:
Canyon::init() now runs once and reuses the global instance.
Previous versions may have re-initialized the configuration and connections on every test (especially if instance() panicked and tests had to restart initialization).
This new OnceLock approach means fewer file reads, fewer TOML parses, and fewer Runtime::new() calls.
Avoiding Re-parsing the config file:
We’re no longer scanning directories and reloading/parsing the config in each test.
This is a huge win if your config file is large or complex.
Connection Caching:
Tokio Runtime Reuse: