set upper bound in cmake_minimum_required #4776
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setting an upper bound improves forward-compatibility as legacy version support is dropped - 3.5 compat is deprecated in 3.27 (2023), removed in 4.0 (2025) - 3.10 compat is deprecated in 3.31 (2024)
|
This will fix configuration error with CMake 4.0. |
|
getting this issue when using fetchcontent in a cmake file with version 4 as minimum as well |
mcloughlan
added a commit
to RMIT-Competition-Rocketry/GCS
that referenced
this pull request
Apr 15, 2025
Also found that fetchcontent will not work for libzmq until zeromq/libzmq#4776 is resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setting an upper bound improves forward-compatibility as legacy version support is dropped. Without an upper bound, the minimum version is used as the policy version, which means that setting a version lower than 3.5 will result in warnings starting with cmake 3.27 and errors starting in 4.0 (release candidate out now). This change allows zeromq to build with cmake 4.