-
Notifications
You must be signed in to change notification settings - Fork 180
feat(protocol-designer, shared-data): add liquid classes form warnings to transfer and mix form #17765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: edge
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #17765 +/- ##
==========================================
- Coverage 61.91% 57.96% -3.95%
==========================================
Files 2949 3091 +142
Lines 227527 244563 +17036
Branches 19185 22771 +3586
==========================================
+ Hits 140882 141773 +891
- Misses 86473 102599 +16126
- Partials 172 191 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
...c/pages/Designer/ProtocolSteps/StepForm/StepTools/MoveLiquidTools/LiquidClassesStepTools.tsx
Outdated
Show resolved
Hide resolved
...c/pages/Designer/ProtocolSteps/StepForm/StepTools/MoveLiquidTools/LiquidClassesStepTools.tsx
Outdated
Show resolved
Hide resolved
...c/pages/Designer/ProtocolSteps/StepForm/StepTools/MoveLiquidTools/LiquidClassesStepTools.tsx
Outdated
Show resolved
Hide resolved
...c/pages/Designer/ProtocolSteps/StepForm/StepTools/MoveLiquidTools/LiquidClassesStepTools.tsx
Outdated
Show resolved
Hide resolved
...c/pages/Designer/ProtocolSteps/StepForm/StepTools/MoveLiquidTools/LiquidClassesStepTools.tsx
Show resolved
Hide resolved
...c/pages/Designer/ProtocolSteps/StepForm/StepTools/MoveLiquidTools/LiquidClassesStepTools.tsx
Outdated
Show resolved
Hide resolved
At first glance, I notice I am getting a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! left a few nits
...r/ProtocolSteps/StepForm/StepTools/MoveLiquidTools/__tests__/LiquidClassesStepTools.test.tsx
Outdated
Show resolved
Hide resolved
@ncdiehl11 Hey Nick, I updated |
re AUTH-1530
Overview
This PR adds new form warnings to display any incompatible pipette, tip rack, transfer volume, and/or pipette path with liquid classes in the PD transfer step. It also disables incompatible liquid class options.
The design specifies replacing <pipette/labware> with the source labware, destination labware, or pipette. Currently, I'm replacing labware with tip rack because we don’t have information about incompatible source and destination labware.
Design: https://www.figma.com/design/RcHb9UdygVtyXcvDcDmnTP/Feature%3A-Liquid-Classes?node-id=1833-28759&t=6C60uZBriQj1doAs-4
Test Plan and Hands on Testing
Changelog
-Updated the
LiquidClassesStepTools
to handle disabling incompatible liquid classes options-Updated the warnings file to add
lowVolumeTransfer
,incompatiblePipettePath
,incompatibleAllPipetteLabware
, andincompatibleSomePipetteLabware
warnings.-Used
getFlexNameConversion
to get pipette load names-Added
getDisableLiquidClasses
to determines which liquid classes should be disabled based on the pipette model, tip rack, volume, and dispense path-Added
getIncompatibleLiquidClasses
returns a list of liquid class names that are incompatible based on a given predicate-Added tests
Review requests
Risk assessment