Skip to content

feat(protocol-designer, shared-data): add liquid classes form warnings to transfer and mix form #17765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: edge
Choose a base branch
from

check formData to select default liquid class

1e5ac61
Select commit
Loading
Failed to load commit list.
Open

feat(protocol-designer, shared-data): add liquid classes form warnings to transfer and mix form #17765

check formData to select default liquid class
1e5ac61
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 1, 2025 in 0s

57.96% (-3.95%) compared to 26345e1

View this Pull Request on Codecov

57.96% (-3.95%) compared to 26345e1

Details

Codecov Report

Attention: Patch coverage is 82.99595% with 42 lines in your changes missing coverage. Please review.

Project coverage is 57.96%. Comparing base (26345e1) to head (1e5ac61).
Report is 7 commits behind head on edge.

Files with missing lines Patch % Lines
...tocol-designer/src/steplist/formLevel/warnings.tsx 77.52% 20 Missing ⚠️
shared-data/js/helpers/index.ts 69.64% 17 Missing ⚠️
...igner/src/steplist/formLevel/test/warnings.test.ts 95.52% 3 Missing ⚠️
...epTools/MoveLiquidTools/LiquidClassesStepTools.tsx 92.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #17765      +/-   ##
==========================================
- Coverage   61.91%   57.96%   -3.95%     
==========================================
  Files        2949     3091     +142     
  Lines      227527   244563   +17036     
  Branches    19185    22771    +3586     
==========================================
+ Hits       140882   141773     +891     
- Misses      86473   102599   +16126     
- Partials      172      191      +19
Files with missing lines Coverage Δ
...rotocolSteps/StepForm/StepTools/MixTools/index.tsx 19.75% <100.00%> (-77.17%) ⬇️
...Steps/StepForm/StepTools/MoveLiquidTools/index.tsx 76.92% <100.00%> (-7.86%) ⬇️
protocol-designer/src/steplist/formLevel/index.ts 48.38% <100.00%> (-7.17%) ⬇️
shared-data/js/constants.ts 100.00% <100.00%> (ø)
...epTools/MoveLiquidTools/LiquidClassesStepTools.tsx 88.54% <92.00%> (-11.46%) ⬇️
...igner/src/steplist/formLevel/test/warnings.test.ts 99.17% <95.52%> (-0.83%) ⬇️
shared-data/js/helpers/index.ts 56.49% <69.64%> (-0.43%) ⬇️
...tocol-designer/src/steplist/formLevel/warnings.tsx 80.14% <77.52%> (-15.62%) ⬇️

... and 549 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov