Skip to content

feat(protocol-designer,-step-generation): update moveLiquidFormToArgs common args #18078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 16, 2025

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Apr 15, 2025

Overview

This PR updates moveLiquidFormToArgs common args to accept new positions for submerge, retract, and aspirate/dispense delays (x, y, and position reference).

Test Plan and Hands on Testing

Not too much to test in the app itself. Please review code for now.

Changelog

  • update getDelayData helper (will be pared down soon)
  • add new args to moveLiquidFormToArgs
  • fix tests
  • refactor types

Review requests

see test plan

Risk assessment

low

… common args

This PR updates moveLiquidFormToArgs common args to accept new positions for submerge, retract, and aspirate/dispense delays (x, y, and position reference).
@ncdiehl11 ncdiehl11 changed the title feat(protocol-designer,-step-generation): update moveLiquidFormToArgs… feat(protocol-designer,-step-generation): update moveLiquidFormToArgs common args Apr 15, 2025
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 86.66667% with 16 lines in your changes missing coverage. Please review.

Project coverage is 24.17%. Comparing base (5d02721) to head (a618f6a).
Report is 6 commits behind head on edge.

Files with missing lines Patch % Lines
...ickTransferFlow/utils/generateQuickTransferArgs.ts 0.00% 16 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #18078      +/-   ##
==========================================
- Coverage   25.59%   24.17%   -1.43%     
==========================================
  Files        2995     3008      +13     
  Lines      232829   235176    +2347     
  Branches    20089    20162      +73     
==========================================
- Hits        59596    56857    -2739     
- Misses     173218   178305    +5087     
+ Partials       15       14       -1     
Flag Coverage Δ
app 1.29% <0.00%> (-1.88%) ⬇️
protocol-designer 18.73% <86.66%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
protocol-designer/src/form-types.ts 80.64% <ø> (ø)
.../steplist/formLevel/stepFormToArgs/getDelayData.ts 100.00% <100.00%> (ø)
...t/formLevel/stepFormToArgs/moveLiquidFormToArgs.ts 92.23% <100.00%> (+1.39%) ⬆️
...formLevel/stepFormToArgs/test/getDelayData.test.ts 100.00% <100.00%> (ø)
...l/stepFormToArgs/test/moveLiquidFormToArgs.test.ts 100.00% <100.00%> (ø)
...rmLevel/stepFormToArgs/test/stepFormToArgs.test.ts 100.00% <100.00%> (ø)
...ickTransferFlow/utils/generateQuickTransferArgs.ts 0.00% <0.00%> (ø)

... and 134 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ncdiehl11 ncdiehl11 self-assigned this Apr 15, 2025
@ncdiehl11 ncdiehl11 requested review from koji and jerader April 15, 2025 21:43
@ncdiehl11 ncdiehl11 marked this pull request as ready for review April 15, 2025 22:00
@ncdiehl11 ncdiehl11 requested review from a team as code owners April 15, 2025 22:00
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i left a couple of comments.
the changes look good to me!

@ncdiehl11 ncdiehl11 merged commit 91ae5e7 into edge Apr 16, 2025
40 checks passed
@ncdiehl11 ncdiehl11 deleted the pd_feat-moveLiquidFormToArgs branch April 16, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants