-
Notifications
You must be signed in to change notification settings - Fork 180
feat(protocol-designer,-step-generation): update moveLiquidFormToArgs common args #18078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… common args This PR updates moveLiquidFormToArgs common args to accept new positions for submerge, retract, and aspirate/dispense delays (x, y, and position reference).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #18078 +/- ##
==========================================
- Coverage 25.59% 24.17% -1.43%
==========================================
Files 2995 3008 +13
Lines 232829 235176 +2347
Branches 20089 20162 +73
==========================================
- Hits 59596 56857 -2739
- Misses 173218 178305 +5087
+ Partials 15 14 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
app/src/organisms/ODD/QuickTransferFlow/utils/generateQuickTransferArgs.ts
Outdated
Show resolved
Hide resolved
app/src/organisms/ODD/QuickTransferFlow/utils/generateQuickTransferArgs.ts
Outdated
Show resolved
Hide resolved
protocol-designer/src/steplist/formLevel/stepFormToArgs/getDelayData.ts
Outdated
Show resolved
Hide resolved
protocol-designer/src/steplist/formLevel/stepFormToArgs/getDelayData.ts
Outdated
Show resolved
Hide resolved
protocol-designer/src/steplist/formLevel/stepFormToArgs/getDelayData.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i left a couple of comments.
the changes look good to me!
… getMoveLiquidDelayData and getMixData utilities
Overview
This PR updates moveLiquidFormToArgs common args to accept new positions for submerge, retract, and aspirate/dispense delays (x, y, and position reference).
Test Plan and Hands on Testing
Not too much to test in the app itself. Please review code for now.
Changelog
getDelayData
helper (will be pared down soon)moveLiquidFormToArgs
Review requests
see test plan
Risk assessment
low