Skip to content

feat(protocol-designer,-step-generation): update moveLiquidFormToArgs common args #18078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 16, 2025

fix(protocol-designer): allow delay field mmFromBottom to be 0

a618f6a
Select commit
Loading
Failed to load commit list.
Merged

feat(protocol-designer,-step-generation): update moveLiquidFormToArgs common args #18078

fix(protocol-designer): allow delay field mmFromBottom to be 0
a618f6a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 16, 2025 in 1s

24.17% (-1.43%) compared to 5d02721

View this Pull Request on Codecov

24.17% (-1.43%) compared to 5d02721

Details

Codecov Report

Attention: Patch coverage is 86.66667% with 16 lines in your changes missing coverage. Please review.

Project coverage is 24.17%. Comparing base (5d02721) to head (a618f6a).
Report is 5 commits behind head on edge.

Files with missing lines Patch % Lines
...ickTransferFlow/utils/generateQuickTransferArgs.ts 0.00% 16 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #18078      +/-   ##
==========================================
- Coverage   25.59%   24.17%   -1.43%     
==========================================
  Files        2995     3008      +13     
  Lines      232829   235176    +2347     
  Branches    20089    20162      +73     
==========================================
- Hits        59596    56857    -2739     
- Misses     173218   178305    +5087     
+ Partials       15       14       -1
Files with missing lines Coverage Δ
protocol-designer/src/form-types.ts 80.64% <ø> (ø)
.../steplist/formLevel/stepFormToArgs/getDelayData.ts 100.00% <100.00%> (ø)
...t/formLevel/stepFormToArgs/moveLiquidFormToArgs.ts 92.23% <100.00%> (+1.39%) ⬆️
...formLevel/stepFormToArgs/test/getDelayData.test.ts 100.00% <100.00%> (ø)
...l/stepFormToArgs/test/moveLiquidFormToArgs.test.ts 100.00% <100.00%> (ø)
...rmLevel/stepFormToArgs/test/stepFormToArgs.test.ts 100.00% <100.00%> (ø)
...ickTransferFlow/utils/generateQuickTransferArgs.ts 0.00% <0.00%> (ø)

... and 134 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov