Fix image to text node, it was bugged #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
PeriniM
reviewed
Apr 3, 2024
|
|
||
| Methods: | ||
| execute(state, url): Execute the node's logic and return the updated state. | ||
| """ | ||
|
|
||
| def __init__(self, llm, node_name: str): | ||
| def __init__(self, input: str, output: List[str], model_config: dict, | ||
| node_name: str = "GetProbableTags"): |
PeriniM
reviewed
Apr 3, 2024
| """ | ||
| super().__init__(node_name, "node") | ||
| self.llm = llm | ||
| super().__init__(node_name, "node", input, output, 2, model_config) |
There was a problem hiding this comment.
should accept only 1 input which is the url or list of url present in the state
PeriniM
reviewed
Apr 3, 2024
| print("---GENERATING TEXT FROM IMAGE---") | ||
| text_answer = self.llm.run(url) | ||
| text_answer = self.llm_model.run(url) |
There was a problem hiding this comment.
missing the retrieval part from the state before this line to get the url
PeriniM
reviewed
Apr 3, 2024
| super().__init__(node_name, "node") | ||
| self.llm = llm | ||
| super().__init__(node_name, "node", input, output, 2, model_config) | ||
| self.llm_model = model_config["llm_model"] | ||
|
|
||
| def execute(self, state: dict, url: str) -> dict: |
There was a problem hiding this comment.
here we can remove the url arg since we use our graph syntax for state retrieval
VinciGit00
commented
Apr 3, 2024
| @@ -71,8 +71,7 @@ def _create_llm(self, llm_config: dict): | |||
| return OpenAI(llm_params) | |||
| elif "gemini" in llm_params["model"]: | |||
| return Gemini(llm_params) | |||
| else: | |||
| raise ValueError("Model not supported") | |||
| raise ValueError("Model not supported") | |||
PeriniM
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.